ChoiceOf constraint is broken

[Brian Warner]

robk ran into this one. I think the patch is to add a method override to PolyConstraint:

    def checkToken(self, typebyte, size):
        ok = False
        for c in self.alternatives:
            try:
                c.checkToken(typebyte, size)
                ok = True
            except (Violation, BananaError):
                pass
        if not ok:
            raise Violation("does not satisfy any of %s" \
                            % (self.alternatives,))

Although it seems like the raise BananaError in Constraint.checkToken (used as the default for a lot of Constraint subclasses) is inappropriate, and maybe it should be raising a Violation instead. I'll have to think about the implications of that.

[Brian Warner]

Fixed, in [258df6096f2d406b23550a2c17b936af9026f517]