Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#274 closed defect (fixed)

Tub.stopService returns a Deferred that may fire before all of the Tub's Brokers have disconnected

Reported by: Jean-Paul Calderone Owned by:
Priority: major Milestone: 0.12.7
Component: network Version: 0.12.5
Keywords: Cc:

Description

Tub.stopService doesn't try to wait for the Brokers to disconnect. It merely calls shutdown on them. In most cases, because of the fireEventually, the Brokers will indeed have disconnected by the time stopService's Deferred fires. However, it's not guaranteed. And, indeed, it recently failed to happen and caused a Tahoe-LAFS CI failure leading to this ticket: ​https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2896.

Change History (4)

comment:1 Changed 7 years ago by Jean-Paul Calderone

Keywords: review-needed added

​https://github.com/warner/foolscap/pull/38

comment:2 Changed 7 years ago by Brian Warner

Component: unknown → network
Keywords: review-needed removed
Milestone: undecided → 0.13.0

Looks good, landing shortly.

comment:3 Changed 7 years ago by Brian Warner

Resolution: → fixed
Status: new → closed

Closed by [88e4f629]

comment:4 Changed 7 years ago by Brian Warner

Milestone: 0.13.0 → 0.12.7
Note: See TracTickets for help on using tickets.