Opened 8 years ago

Closed 8 years ago

#259 closed defect (fixed)

listenOn doesn't accept valid endpoint strings

Reported by: dawuud Owned by:
Priority: major Milestone: undecided
Component: network Version: 0.9.1
Keywords: Cc:

Description

this regular expression: ​https://github.com/warner/foolscap/blob/2813a289dafc419ebb2886b5825de7f86c4cf7d2/src/foolscap/pb.py#L503

has got to be wrong if the intention is to allow valid server endpoint descriptor strings. once such valid string which is not allowed by this regex is:

` tcp:interface=127.0.0.1:1234 `

Change History (1)

comment:1 Changed 8 years ago by Brian Warner

Component: unknown → network
Resolution: → fixed
Status: new → closed

I think we can close this now: listenOn should take anything that's a valid server-endpoint descriptor. The regexp in question is only used to decide when to warn about a deprecated port-number-only form. Normal "tcp:PORT" or "tcp:PORT:interface=" forms won't be matched by that regexp and will be passed to endpoints.serverFromString() without changes.

Note: See TracTickets for help on using tickets.