Opened 9 years ago
#254 new defect
log message: "pre-0.2.0 peer detected" (when all peers are recent)
| Reported by: | Brian Warner | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | undecided |
| Component: | negotiation | Version: | 0.9.1 |
| Keywords: | Cc: |
Description
I'd enabled FLOGFILE= logging for a tahoe unit test run (specifically allmydata.test.test_system.SystemTest.test_filesystem_with_cli_in_subprocess from trunk, which is getting DirtyReactorErrors against a wide variety of Foolscap versions), and noticed the following CURIOUS log message:
pre-0.2.0 peer detected (no my-incarnation or last-connection)
This is coming from Negotiation.compareOfferAndExisting, and looks like it's been happening for a while (I was able to see it with tahoe-trunk and foolscap-0.9.0).
I think this is a consequence of the TODO note just before the warning: TODO: new servers send my-incarnation but not last-connection.
The task is to figure out whether this warning should be displayed, and whether the related handle-old-connections code should be run, and fix things so that the warning is not displayed for modern peers. It might be appropriate to just delete that whole thing, since foolscap-0.2.0 was released over 8 years ago.
