Opened 11 years ago

Last modified 8 years ago

#212 new defect

replace foolscap.test.common.ShouldFailMixin.shouldFail with twisted.trial.unittest.TestCase.failUnlessFailure ? — at Version 1

Reported by: Zooko Owned by:
Priority: major Milestone: eventually
Component: unknown Version: 0.6.4
Keywords: Cc:

Description (last modified by Brian Warner)

The foolscap shouldFail thing can require substrings, so maybe we need to use twisted.trial.unittest.TestCase.failUnlessSubstring too.

Change History (1)

comment:1 Changed 11 years ago by Brian Warner

Description: modified (diff)
Milestone: undecided → 0.6.5

I'm all for removing code, but we're currently compatible all the way back to Twisted-2.5.0, and I'd like to know what we're giving up to make a change like that.

In which version of Twisted did failUnlessFailure first appear?

(also, I think we probably have multiple versions of shouldFail, so we can probably consolidate them at the same time).

Note: See TracTickets for help on using tickets.