Opened 14 years ago

Closed 14 years ago

#165 closed defect (fixed)

eventual.py has two unnecessary lines

Reported by: ivank Owned by:
Priority: trivial Milestone: 0.6.1
Component: unknown Version: 0.5.1
Keywords: Cc:

Description

In eventual.py, the body of this if block is never run (unless of course some callback mutates _events instead of calling append)

        if self._events and not self._timer:
            self._timer = reactor.callLater(0, self._turn)

I don't think it's needed because _SimpleCallQueue.append sets self._timer.

Change History (1)

comment:1 Changed 14 years ago by Brian Warner

Milestone: undecided0.6.1
Resolution: fixed
Status: newclosed

I concur. Fixed in [7904b98a03324479b6c26a0b7a8ba51052302a09]. Thanks!

Note: See TracTickets for help on using tickets.