Opened 14 years ago

Closed 14 years ago

#156 closed defect (fixed)

setup.py packages= is wrong: use foolscap.logging not foolscap/logging

Reported by: Brian Warner Owned by:
Priority: major Milestone: 0.6.0
Component: packaging Version: 0.4.1
Keywords: Cc:

Description

A ​setuptools bug (see pje's comment in msg381) points out that Foolscap's setup.py is misusing the packages= keyword: the specs call for a list of package names, not paths. So when our setup.py says "foolscap/slicers", it should really say "foolscap.slicers". The consequence is that subsequent setuptools consistency checks are messed up, and noisy warning messages appear (and possibly other code fails to believe that Foolscap is really installed).

The fix is pretty simple, we just need to do some testing afterwards.

Change History (3)

comment:1 Changed 14 years ago by Brian Warner

Fixed in [7c7b1185b68076cc6176ea41b5fc677445e1e45b] . I still want to do some more testing before marking this one closed.

comment:2 Changed 14 years ago by Zooko

I guess we can close this now! I reviewed the patch [7c7b1185b68076cc6176ea41b5fc677445e1e45b] and it looks correct to me.

comment:3 Changed 14 years ago by Brian Warner

Resolution: → fixed
Status: new → closed

cool, thanks!

Note: See TracTickets for help on using tickets.