Opened 14 years ago
Closed 14 years ago
#154 closed defect (fixed)
FLOGTOTWISTED=1 doesn't honor FLOGLEVEL=
| Reported by: | Brian Warner | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.6.0 |
| Component: | logging | Version: | 0.4.1 |
| Keywords: | Cc: |
Description
Zooko discovered (after a painful debugging process) that running a Trial-based unit test suite with "FLOGFILE=flog.out FLOGLEVEL=1 FLOGTOTWISTED=1" emits different messages to the flog.out flogfile than to trial's _trial_temp/log.out . The former gets all messages (including level=NOISY, which are only recorded because of the FLOGLEVEL=1 setting). The latter is hardwired to strip out messages below the level=OPERATIONAL threshold, excluding NOISY. He expected both flog.out and twisted's log.out to contain the same events.
The fix is to change the code in source:foolscap/logging/log.py (at the end of the file) that pays attention to FLOGTOTWISTED=1 to also parse FLOGLEVEL, and create a filter function that uses FLOGLEVEL as a threshold.
Change History (3)
comment:1 Changed 14 years ago by
comment:2 Changed 14 years ago by
| Milestone: | undecided → 0.6.0 |
|---|
comment:3 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Tahoe-LAFS' docs/logging.txt now documents this issue. Please remove that note once it is fixed, and Tahoe-LAFS has been updated to depend on the fixed version of foolscap.