add SOCKS proxy handler to foolscap

[Brian Warner]

Something like:

from foolscap.connection_plugins import SOCKSTCP

h = SOCKSTCP("tcp:localhost:9050")
tub.removeAllConnectionHintHandlers()
tub.addConnectionHintHandler(h)

You'd need to depend upon foolscap[socks] >= 0.9.1 to use this, and this would trigger a dependency on ​txsocksx.

It might also be nice to make the class accept a list of hint-prefixes to handle (defaulting to just "tcp:"), so that you could also use this to handle "tor:" hints. Before doing that, we should probably change the internals of hint processing to translate old-style "host:port" hints into "tcp:host:port", so that plugins don't need to do that themselves.

[dawuud]

ok... based on warner's tor branch i made this: ​https://github.com/david415/foolscap/tree/tor-client-plugin.0

it's a socks client plugin called TorPlugin? but we can rename it to SocksPlugin? or whatever.

[dawuud]

I added some unit tests for the tor/socks plugin: ​https://github.com/warner/foolscap/pull/21/files

[Brian Warner]

the logging fixes (#244) take priority, pushing this out a release

[Brian Warner]

Milestone renamed

[davidsarah]

New branch with tests: ​https://github.com/david415/foolscap/tree/tor-client-plugin.1

[davidsarah]

This was based off an older version of foolscap (0.6.5 IIRC), I rebased it to master here: ​https://github.com/daira/foolscap/tree/tor-client-plugin.2

[dawuud]

Here's the latest after I merged upstream/master and manually resolved a conflict:

• ​https://github.com/david415/foolscap/tree/tor-client-plugin.3

Tested and it works. Daira reviewed the code.

Here's the current diff with upstream master if anyone would like to further code review: ​https://github.com/warner/foolscap/pull/25/files

[dawuud]

I received a code review from Brian Warner and I have tried to fix all the things he said to fix; although I have not yet rebased and squashed my messy commit history. We can continue to utilize this dev branch/pull request for code review until we consider it ready and then i'll squash and rebase it.

​https://github.com/david415/foolscap/tree/tor-client-plugin.3 ​https://github.com/warner/foolscap/pull/25

[dawuud]

i also made this dev branch with foolscap upstream master merged in: ​https://github.com/david415/foolscap/tree/tor-client-plugin.4

what's the next step to getting this ready to be merged?

[Brian Warner]

I added a big list of recommended changes to the pull request

[Brian Warner]

BTW, I'm going to change the API of IConnectionHintHandler.hint_to_endpoint to allow it to return a Deferred (that fires with a tuple of (endpoint, host)) instead of requiring it to return synchronously. This should make the #246 Tor handler easier to write (since it can try to connect/launch Tor before returning the endpoint). Feel free to take advantage of this in the SOCKS plugin, if it helps at all.

[Brian Warner]

Moving these tickets from 0.12 to 0.13, since we need 0.12 out quickly to resolve #263

[Brian Warner]

Landed in [50762026].