list-mutation race in Tub.stopService

[Brian Warner]

While tracking down a Tahoe test failure, I discovered that pb.Tub.stopService is iterating over the list of self.reconnectors, stopping them one-by-one, but that Reconnector.stopConnecting is also removing them from the list. Mutating a list while you're iterating over it is a no-no, and was resulting in the Tahoe test failing to shut down some of the reconnector's timers, leading to a Dirty Reactor Error.

The fix is easy: wrap that thing in a list() before iterating over it.

[Brian Warner]

Fixed in [900c2b4]