Opened 13 years ago
Closed 13 years ago
#176 closed enhancement (fixed)
support multiple log gatherers passed in as API arguments instead of through a file
| Reported by: | Zooko | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.6.2 |
| Component: | logging | Version: | 0.6.1 |
| Keywords: | Cc: |
Description
Currently you can pass any number of log gatherer furls in a file, and you can pass up to one in a call to setOption("log-gatherer-furl", ...), and foolscap will union those two inputs.
Please make it possible to pass more than one with a setOption() call.
As far as I can see it would be backward-compatible if you just detected the second argument to setOption("log-gatherer-furl", ...) being a set and used all of its elements.
In Tahoe-LAFS we are removing the old style of having a configuration file for each item and instead putting everything into tahoe.cfg, so I would rather not have this log_gatherer.furl file in the Tahoe-LAFS basedir and instead have all of the log gatherer furls encoded into the tahoe.cfg file, but currently we cannot pass all of such furls to foolscap.
Change History (3)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Submitted a pull request with a patch for this https://github.com/warner/foolscap/pull/3
comment:3 Changed 13 years ago by
| Milestone: | undecided → 0.6.2 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Applied in [97412e6]. Thanks!
http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1385#comment:6 has a lot more detail about the affect of this issue on Tahoe-LAFS.