Changes between Initial Version and Version 1 of Ticket #203, comment 55


Ignore:
Timestamp:
04/06/2016 06:21:14 PM (8 years ago)
Author:
Brian Warner
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #203, comment 55

    initial v1  
    11Reviewing this just now, I'm much more in favor of passing a real Endpoint to `Tub.listenOn(ep)`, instead of a string. The caller can be responsible for mapping from whatever configuration language their application uses (e.g. `tahoe.cfg` strings, or some `--listen-on=` CLI argument), into an endpoint of their choosing. No need for listening-side plugins.
    22
    3 At the same time, I think we'll remove the dynamic what-is-my-address what-is-my-port stuff that Listeners were providing before. We'll deprecate the `listenOn("tcp:0")` case (as discussed in [https://tahoe-lafs.org/trac/tahoe-lafs/ticket/517#comment:38 tahoe#517]). (to be picky, you can still call `tub.listenOn("tcp:0")`, but it's a bad idea because you'll have no way to find out what port got allocated, so you won't know what to pass into `tub.setLocation()`).
     3At the same time, I think we'll remove the dynamic what-is-my-address what-is-my-port stuff that Listeners were providing before. We'll deprecate the `listenOn("tcp:0")` case (as discussed in [https://tahoe-lafs.org/trac/tahoe-lafs/ticket/517#comment:38 tahoe#517], and now tracked in foolscap #252). (to be picky, you can still call `tub.listenOn("tcp:0")`, but it's a bad idea because you'll have no way to find out what port got allocated, so you won't know what to pass into `tub.setLocation()`).