Changes between Version 1 and Version 2 of Ticket #203, comment 27


Ignore:
Timestamp:
10/30/2013 09:56:59 PM (11 years ago)
Author:
str4d
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #203, comment 27

    v1 v2  
    1212A FURL contains the required hints for a client to find a server. I think that should directly translate to the required arguments for the client endpoints. Instead of storing `(type, host, port)` for each hint, I propose that either `locationHint`, `(type, locationHint)` or `(type, reqParams)` is stored (where `reqParams` is `locationHint` with `type:` stripped from the front).
    1313
    14 The location hints are eventually used in `foolscap.negotiate.TubConnector.connectToAll()`, which pops a `(host, port)` pair and calls `reactor.connectTCP()` on that pair. This is where `clientFromString()` would instead be used, based on a generated client endpoint description string:
     14This proposal simplifies your patch. You don't need to parse the location hints looking for type-specific parameters, just pass the entire hint through. The only place I see location hints are used is in `foolscap.negotiate.TubConnector.connectToAll()`, which pops a `(host, port)` pair and calls `reactor.connectTCP()` on that pair. This is where `clientFromString()` would instead be used, based on a generated client endpoint description string:
    1515
    1616{{{