id	summary	reporter	owner	description	type	status	priority	milestone	component	version	resolution	keywords	cc
177	writing an incident flogfile tries to use characters not valid in a Windows filename (':')	davidsarah		"[http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1396 Ticket 1396] in Tahoe-LAFS is actually a foolscap bug:

> While reporting the incident in [http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1395 #1395] on a Windows platform, the following error occurred:
> {{{
> [Failure instance: Traceback: <type 'exceptions.IOError'>:
> [Errno 22] invalid mode ('wb') or filename:
> u'C:\\tahoeclient\\logs\\incidents\\incident-2011-05-05--18:33:34Z-w2qn32q.flog'
> }}}
> 
> The problem (or at least one problem) is that '{{{:}}}' is not valid in a Windows filename. [http://msdn.microsoft.com/en-us/library/aa365247%28v=vs.85%29.aspx This MSDN article] documents the Windows filename validity rules.
> 
> Presumably we don't have any test of writing an incident flogfile. This may mean that incident reporting has always been broken on Windows (unless the flogfile naming changed?)
...
> The problem is... apparently due to the time format [http://foolscap.lothar.com/trac/browser/foolscap/logging/incident.py?rev=77d2c68#L59 here] in {{{foolscap/logging/incident.py}}}:
> {{{
> TIME_FORMAT = ""%Y-%m-%d--%H:%M:%S""
> }}}
> which is used indirectly by {{{incident_declared}}} to create the filename.
"	defect	closed	major	0.6.2	logging	0.6.1	fixed	win32 error incident logging regression