foolscap.call.CopiedFailure.printTraceback wants log.logerr, but it doesn't exist.

[ivank]

The offending line is if file is None: file = log.logerr

I don't think logerr exists.

[Brian Warner]

Hrm. It looks like calling regular old twisted.python.failure.Failure.printTraceback with file=None will cause the lines of stack frames to be sent to twisted.python.log.msg, with an extra isError=1 marker. So we have a couple of choices:

• send them to the same place (the twisted log)
• hand them to Foolscap's internal log mechanism
• write them to stderr

I suppose it makes the most sense to send them to the twisted log.msg, using the same convention that Failure.printTraceback uses. That probably means we'll need to do something in call.py like:

from twisted.python import log as twlog
...
if file is None: file = twlog.logerr

[sp]

Fixes for both the log.logerr bug and a deprecation warning in banana.py

[sp]

I just attached a file fixing this problem and fixing a deprecation warning in foolscap/banana.py. The file is in "hg export" format.

[Brian Warner]

Landed, at long last, in [9e2f8933946a8f5bb2631209f1998b3d31ff42db]. The sets issue was fixed a long time ago (and we no longer allow pythons that are old enough to need it anyways). Thanks!