Ticket #21 (new enhancement)

Opened 3 years ago

Last modified 7 months ago

log failures better: add caller stack

Reported by: warner Assigned to:
Priority: major Milestone: eventually
Component: logging Version: 0.1.6
Keywords: Cc:

Description

When a method fails, we can log some information about it (if that option is turned on in the Tub). The information logged looks like this: 

2007/09/08 19:10 -0700 [Negotiation,client] an outbound callRemote (that we sent to someone else) failed on the far end
2007/09/08 19:10 -0700 [Negotiation,client]  reqID=858, rref=<RemoteReference at 0x48b37174 [pb://onxnl2fpfqruabaku26fa4t5543vj3at@207.7.153.181:36611,127.0.0.1:36611/vdrive]>, methname=get

and includes the remote stack trace.

This information is missing the following useful pieces:

  • the RemoteInterface? in use: that methname=get is hard to use without knowing exactly which "get" method we're talking about
  • the stack trace (or at least the top-most frame) of the callRemote(), so we can find out why we were sending this message

Change History

09/08/07 19:21:38 changed by warner

  • version changed from 0.1.5 to 0.1.6.

12/07/07 18:23:20 changed by warner

  • owner changed.
  • component changed from unknown to logging.

07/02/08 15:38:57 changed by warner

it looks like the interface name should be included in that log message in [471339eda190], which was released in foolscap-0.1.7 .

So the only remaining piece is the stack trace (or a few frames of it) that led up the the callRemote().

07/07/08 19:44:15 changed by warner

  • milestone changed from undecided to 0.3.0.

09/03/08 11:57:17 changed by warner

  • milestone changed from 0.3.1 to 0.3.2.

first task is to measure how long it takes to capture a short stack frame. If it's less than a millisecond I'm ok with adding it to callRemote.

05/19/09 16:26:30 changed by warner

  • summary changed from log failures better to log failures better: add caller stack.
  • milestone changed from 0.3.3 to 0.4.0.

01/11/10 18:10:20 changed by warner

  • milestone changed from 0.5.0 to eventually.