Changeset 462:fe557ab53977

Timestamp:

08/04/08 22:58:52 (5 months ago)

Author:

"Brian Warner <warner@lothar.com>"

branch:

default

Message:

RemoteReference?.getRemoteTubID: make this secure

Files:

• ChangeLog (modified) (1 diff)
• foolscap/referenceable.py (modified) (1 diff)
• foolscap/test/test_pb.py (modified) (1 diff)

ChangeLog

@@ -1 +1 @@
-2008-08-04  Brian Warner  <warner@lothar.com>
+
+        * foolscap/referenceable.py (RemoteReferenceOnly.getRemoteTubID):
+        make this secure, by using the broker's .remote_tubref field,
+        instead of the remote-side-controlled sturdyref.
+        (RemoteReferenceOnly.getSturdyRef): add a note about the
+        insecurity of this method
+        * foolscap/test/test_pb.py (TestCallable.testGetSturdyRef): add a
+        test for getRemoteTubID
-
-        * doc/logging.xhtml: change filenames in the incident-gatherer to

foolscap/referenceable.py

@@ -338 +338 @@
-
-    def getSturdyRef(self):
+        # note that this is currently *not* secure: the remote end gets to
+        # control all parts of this FURL, including the tubid
-        return SturdyRef(self.tracker.getURL())
-    def getRemoteTubID(self):
-
+
+
+
+
-
-    def getPeer(self):

foolscap/test/test_pb.py

@@ -418 +418 @@
-            self.failUnlessEqual(peer.type, "TCP")
-            self.failUnlessEqual(peer.host, "127.0.0.1")
+            self.failUnlessEqual(rref.getRemoteTubID(), self.tubB.getTubID())
-        d.addCallback(_check)
-        return d