Changeset 458:997c2d633f6d

Timestamp:

08/01/08 19:59:27 (5 months ago)

Author:

"Brian Warner <warner@lothar.com>"

branch:

default

Message:

make LogFileObserver? more useful, don't do addSystemEventTrigger in init

Files:

• ChangeLog (modified) (1 diff)
• foolscap/logging/log.py (modified) (2 diffs)

ChangeLog

@@ -1 +1 @@
-2008-08-01  Brian Warner  <warner@lothar.com>
+
+        * foolscap/logging/log.py (LogFileObserver): make these more
+        useful, by not doing the addSystemEventTrigger in __init__
+        (LogFileObserver.stop_on_shutdown): do it here instead
+        (FLOGFILE): when using $FLOGFILE, add call to stop_on_shutdown
-
-        * foolscap/logging/gatherer.py (GathererService.do_rotate): oops,

foolscap/logging/log.py

@@ -363 +363 @@
-                             }}
-        pickle.dump(header, self._logFile)
+
+    def stop_on_shutdown(self):
-        from twisted.internet import reactor
-        reactor.addSystemEventTrigger("after", "shutdown", self._stop)
@@ -392 +394 @@
-        _floglevel = int(os.environ.get("FLOGLEVEL", str(OPERATIONAL)))
-        lfo = LogFileObserver(_flogfile, _floglevel)
+        lfo.stop_on_shutdown()
-        theLogger.addObserver(lfo.msg)
-        #theLogger.set_generation_threshold(UNUSUAL, "foolscap.negotiation")